[Chore] Neaten Routes #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ac7e5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
commented
Jul 25, 2024
|
|
||
| export const syncStreamReactive: SocketRouteGenerator = (router) => | ||
| router.reactiveStream<util.StreamingSyncRequest, any>(SyncRoutes.STREAM, { | ||
| authorize: ({ context }) => { |
Collaborator
Author
There was a problem hiding this comment.
The token is now checked on the connection level. This is no longer necessary.
rkistner
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
@powersync/service-corepackage currently exports various route definitions and some functions for registering the routes on a server.Routes are usually registered in the
serverrunner inside the projectservicefolder/package. The current configuration required duplication of the route registration between different projects.This PR introduces utility functions which perform the common route registration. The registration itself is still configurable if projects require custom functionality.